feat: add MCP server headers support #22718 (#24760)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
Co-authored-by: Novice <novice12185727@gmail.com>
This commit is contained in:
Cluas
2025-09-08 14:10:55 +08:00
committed by GitHub
parent 5d0a50042f
commit f891c67eca
15 changed files with 441 additions and 32 deletions

View File

@@ -0,0 +1,143 @@
'use client'
import React, { useCallback } from 'react'
import { useTranslation } from 'react-i18next'
import { RiAddLine, RiDeleteBinLine } from '@remixicon/react'
import Input from '@/app/components/base/input'
import Button from '@/app/components/base/button'
import ActionButton from '@/app/components/base/action-button'
import cn from '@/utils/classnames'
export type HeaderItem = {
key: string
value: string
}
type Props = {
headers: Record<string, string>
onChange: (headers: Record<string, string>) => void
readonly?: boolean
isMasked?: boolean
}
const HeadersInput = ({
headers,
onChange,
readonly = false,
isMasked = false,
}: Props) => {
const { t } = useTranslation()
const headerItems = Object.entries(headers).map(([key, value]) => ({ key, value }))
const handleItemChange = useCallback((index: number, field: 'key' | 'value', value: string) => {
const newItems = [...headerItems]
newItems[index] = { ...newItems[index], [field]: value }
const newHeaders = newItems.reduce((acc, item) => {
if (item.key.trim())
acc[item.key.trim()] = item.value
return acc
}, {} as Record<string, string>)
onChange(newHeaders)
}, [headerItems, onChange])
const handleRemoveItem = useCallback((index: number) => {
const newItems = headerItems.filter((_, i) => i !== index)
const newHeaders = newItems.reduce((acc, item) => {
if (item.key.trim())
acc[item.key.trim()] = item.value
return acc
}, {} as Record<string, string>)
onChange(newHeaders)
}, [headerItems, onChange])
const handleAddItem = useCallback(() => {
const newHeaders = { ...headers, '': '' }
onChange(newHeaders)
}, [headers, onChange])
if (headerItems.length === 0) {
return (
<div className='space-y-2'>
<div className='body-xs-regular text-text-tertiary'>
{t('tools.mcp.modal.noHeaders')}
</div>
{!readonly && (
<Button
variant='secondary'
size='small'
onClick={handleAddItem}
className='w-full'
>
<RiAddLine className='mr-1 h-4 w-4' />
{t('tools.mcp.modal.addHeader')}
</Button>
)}
</div>
)
}
return (
<div className='space-y-2'>
{isMasked && (
<div className='body-xs-regular text-text-tertiary'>
{t('tools.mcp.modal.maskedHeadersTip')}
</div>
)}
<div className='overflow-hidden rounded-lg border border-divider-regular'>
<div className='system-xs-medium-uppercase bg-background-secondary flex h-7 items-center leading-7 text-text-tertiary'>
<div className='h-full w-1/2 border-r border-divider-regular pl-3'>{t('tools.mcp.modal.headerKey')}</div>
<div className='h-full w-1/2 pl-3 pr-1'>{t('tools.mcp.modal.headerValue')}</div>
</div>
{headerItems.map((item, index) => (
<div key={index} className={cn(
'flex items-center border-divider-regular',
index < headerItems.length - 1 && 'border-b',
)}>
<div className='w-1/2 border-r border-divider-regular'>
<Input
value={item.key}
onChange={e => handleItemChange(index, 'key', e.target.value)}
placeholder={t('tools.mcp.modal.headerKeyPlaceholder')}
className='rounded-none border-0'
readOnly={readonly}
/>
</div>
<div className='flex w-1/2 items-center'>
<Input
value={item.value}
onChange={e => handleItemChange(index, 'value', e.target.value)}
placeholder={t('tools.mcp.modal.headerValuePlaceholder')}
className='flex-1 rounded-none border-0'
readOnly={readonly}
/>
{!readonly && headerItems.length > 1 && (
<ActionButton
onClick={() => handleRemoveItem(index)}
className='mr-2'
>
<RiDeleteBinLine className='h-4 w-4 text-text-destructive' />
</ActionButton>
)}
</div>
</div>
))}
</div>
{!readonly && (
<Button
variant='secondary'
size='small'
onClick={handleAddItem}
className='w-full'
>
<RiAddLine className='mr-1 h-4 w-4' />
{t('tools.mcp.modal.addHeader')}
</Button>
)}
</div>
)
}
export default React.memo(HeadersInput)

View File

@@ -9,6 +9,7 @@ import AppIcon from '@/app/components/base/app-icon'
import Modal from '@/app/components/base/modal'
import Button from '@/app/components/base/button'
import Input from '@/app/components/base/input'
import HeadersInput from './headers-input'
import type { AppIconType } from '@/types/app'
import type { ToolWithProvider } from '@/app/components/workflow/types'
import { noop } from 'lodash-es'
@@ -29,6 +30,7 @@ export type DuplicateAppModalProps = {
server_identifier: string
timeout: number
sse_read_timeout: number
headers?: Record<string, string>
}) => void
onHide: () => void
}
@@ -66,12 +68,38 @@ const MCPModal = ({
const [appIcon, setAppIcon] = useState<AppIconSelection>(getIcon(data))
const [showAppIconPicker, setShowAppIconPicker] = useState(false)
const [serverIdentifier, setServerIdentifier] = React.useState(data?.server_identifier || '')
const [timeout, setMcpTimeout] = React.useState(30)
const [sseReadTimeout, setSseReadTimeout] = React.useState(300)
const [timeout, setMcpTimeout] = React.useState(data?.timeout || 30)
const [sseReadTimeout, setSseReadTimeout] = React.useState(data?.sse_read_timeout || 300)
const [headers, setHeaders] = React.useState<Record<string, string>>(
data?.masked_headers || {},
)
const [isFetchingIcon, setIsFetchingIcon] = useState(false)
const appIconRef = useRef<HTMLDivElement>(null)
const isHovering = useHover(appIconRef)
// Update states when data changes (for edit mode)
React.useEffect(() => {
if (data) {
setUrl(data.server_url || '')
setName(data.name || '')
setServerIdentifier(data.server_identifier || '')
setMcpTimeout(data.timeout || 30)
setSseReadTimeout(data.sse_read_timeout || 300)
setHeaders(data.masked_headers || {})
setAppIcon(getIcon(data))
}
else {
// Reset for create mode
setUrl('')
setName('')
setServerIdentifier('')
setMcpTimeout(30)
setSseReadTimeout(300)
setHeaders({})
setAppIcon(DEFAULT_ICON as AppIconSelection)
}
}, [data])
const isValidUrl = (string: string) => {
try {
const urlPattern = /^(https?:\/\/)((([a-z\d]([a-z\d-]*[a-z\d])*)\.)+[a-z]{2,}|((\d{1,3}\.){3}\d{1,3})|localhost)(\:\d+)?(\/[-a-z\d%_.~+]*)*(\?[;&a-z\d%_.~+=-]*)?/i
@@ -129,6 +157,7 @@ const MCPModal = ({
server_identifier: serverIdentifier.trim(),
timeout: timeout || 30,
sse_read_timeout: sseReadTimeout || 300,
headers: Object.keys(headers).length > 0 ? headers : undefined,
})
if(isCreate)
onHide()
@@ -231,6 +260,18 @@ const MCPModal = ({
placeholder={t('tools.mcp.modal.timeoutPlaceholder')}
/>
</div>
<div>
<div className='mb-1 flex h-6 items-center'>
<span className='system-sm-medium text-text-secondary'>{t('tools.mcp.modal.headers')}</span>
</div>
<div className='body-xs-regular mb-2 text-text-tertiary'>{t('tools.mcp.modal.headersTip')}</div>
<HeadersInput
headers={headers}
onChange={setHeaders}
readonly={false}
isMasked={!isCreate && Object.keys(headers).length > 0}
/>
</div>
</div>
<div className='flex flex-row-reverse pt-5'>
<Button disabled={!name || !url || !serverIdentifier || isFetchingIcon} className='ml-2' variant='primary' onClick={submit}>{data ? t('tools.mcp.modal.save') : t('tools.mcp.modal.confirm')}</Button>

View File

@@ -59,6 +59,8 @@ export type Collection = {
server_identifier?: string
timeout?: number
sse_read_timeout?: number
headers?: Record<string, string>
masked_headers?: Record<string, string>
}
export type ToolParameter = {
@@ -184,4 +186,5 @@ export type MCPServerDetail = {
description: string
status: string
parameters?: Record<string, string>
headers?: Record<string, string>
}