ruff check preview (#25653)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

api/tests/integration_tests/storage/test_clickzetta_volume.py

@@ -3,6 +3,7 @@
 import os
 import tempfile
 import unittest
+from pathlib import Path
 
 import pytest
 
@@ -60,8 +61,7 @@ class TestClickZettaVolumeStorage(unittest.TestCase):
         # Test download
         with tempfile.NamedTemporaryFile() as temp_file:
             storage.download(test_filename, temp_file.name)
-            with open(temp_file.name, "rb") as f:
-                downloaded_content = f.read()
+            downloaded_content = Path(temp_file.name).read_bytes()
             assert downloaded_content == test_content
 
         # Test scan

api/tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py

@@ -12,6 +12,7 @@ and realistic testing scenarios with actual PostgreSQL and Redis instances.
 
 import uuid
 from datetime import datetime
+from pathlib import Path
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -276,8 +277,7 @@ class TestBatchCreateSegmentToIndexTask:
         mock_storage = mock_external_service_dependencies["storage"]
 
         def mock_download(key, file_path):
-            with open(file_path, "w", encoding="utf-8") as f:
-                f.write(csv_content)
+            Path(file_path).write_text(csv_content, encoding="utf-8")
 
         mock_storage.download.side_effect = mock_download
 
@@ -505,7 +505,7 @@ class TestBatchCreateSegmentToIndexTask:
         db.session.commit()
 
         # Test each unavailable document
-        for i, document in enumerate(test_cases):
+        for document in test_cases:
             job_id = str(uuid.uuid4())
             batch_create_segment_to_index_task(
                 job_id=job_id,
@@ -601,8 +601,7 @@ class TestBatchCreateSegmentToIndexTask:
         mock_storage = mock_external_service_dependencies["storage"]
 
         def mock_download(key, file_path):
-            with open(file_path, "w", encoding="utf-8") as f:
-                f.write(empty_csv_content)
+            Path(file_path).write_text(empty_csv_content, encoding="utf-8")
 
         mock_storage.download.side_effect = mock_download
 
@@ -684,8 +683,7 @@ class TestBatchCreateSegmentToIndexTask:
         mock_storage = mock_external_service_dependencies["storage"]
 
         def mock_download(key, file_path):
-            with open(file_path, "w", encoding="utf-8") as f:
-                f.write(csv_content)
+            Path(file_path).write_text(csv_content, encoding="utf-8")
 
         mock_storage.download.side_effect = mock_download
 

api/tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py

@@ -362,7 +362,7 @@ class TestCleanDatasetTask:
 
         # Create segments for each document
         segments = []
-        for i, document in enumerate(documents):
+        for document in documents:
             segment = self._create_test_segment(db_session_with_containers, account, tenant, dataset, document)
             segments.append(segment)
 

api/tests/unit_tests/core/tools/utils/test_web_reader_tool.py

@@ -15,7 +15,7 @@ class FakeResponse:
         self.status_code = status_code
         self.headers = headers or {}
         self.content = content
-        self.text = text if text else content.decode("utf-8", errors="ignore")
+        self.text = text or content.decode("utf-8", errors="ignore")
 
 
 # ---------------------------

api/tests/unit_tests/services/test_metadata_bug_complete.py

@@ -1,3 +1,4 @@
+from pathlib import Path
 from unittest.mock import Mock, create_autospec, patch
 
 import pytest
@@ -146,19 +147,17 @@ class TestMetadataBugCompleteValidation:
         # Console API create
         console_create_file = "api/controllers/console/datasets/metadata.py"
         if os.path.exists(console_create_file):
-            with open(console_create_file) as f:
-                content = f.read()
-                # Should contain nullable=False, not nullable=True
-                assert "nullable=True" not in content.split("class DatasetMetadataCreateApi")[1].split("class")[0]
+            content = Path(console_create_file).read_text()
+            # Should contain nullable=False, not nullable=True
+            assert "nullable=True" not in content.split("class DatasetMetadataCreateApi")[1].split("class")[0]
 
         # Service API create
         service_create_file = "api/controllers/service_api/dataset/metadata.py"
         if os.path.exists(service_create_file):
-            with open(service_create_file) as f:
-                content = f.read()
-                # Should contain nullable=False, not nullable=True
-                create_api_section = content.split("class DatasetMetadataCreateServiceApi")[1].split("class")[0]
-                assert "nullable=True" not in create_api_section
+            content = Path(service_create_file).read_text()
+            # Should contain nullable=False, not nullable=True
+            create_api_section = content.split("class DatasetMetadataCreateServiceApi")[1].split("class")[0]
+            assert "nullable=True" not in create_api_section
 
 
 class TestMetadataValidationSummary: