fix oxlint warnings (#26634)

2025-10-09 10:23:34 +09:00
parent c4d8bf0ce9
commit a8746bff30
76 changed files with 261 additions and 144 deletions
--- a/web/app/components/workflow/block-selector/tool/tool.tsx
+++ b/web/app/components/workflow/block-selector/tool/tool.tsx
@@ -73,7 +73,7 @@ const Tool: FC<Props> = ({
    if (isHovering && !isAllSelected) {
      return (
        <span className='system-xs-regular text-components-button-secondary-accent-text'
-          onClick={(e) => {
+          onClick={() => {
            onSelectMultiple?.(BlockEnum.Tool, actions.filter(action => !getIsDisabled(action)).map((tool) => {
              const params: Record<string, string> = {}
              if (tool.parameters) {
--- a/web/app/components/workflow/hooks/use-shortcuts.ts
+++ b/web/app/components/workflow/hooks/use-shortcuts.ts
@@ -107,7 +107,8 @@ export const useShortcuts = (): void => {
    const { showDebugAndPreviewPanel } = workflowStore.getState()
    if (shouldHandleShortcut(e) && !showDebugAndPreviewPanel) {
      e.preventDefault()
-      workflowHistoryShortcutsEnabled && handleHistoryBack()
+      if (workflowHistoryShortcutsEnabled)
+        handleHistoryBack()
    }
  }, { exactMatch: true, useCapture: true })

@@ -116,7 +117,8 @@ export const useShortcuts = (): void => {
    (e) => {
      if (shouldHandleShortcut(e)) {
        e.preventDefault()
-        workflowHistoryShortcutsEnabled && handleHistoryForward()
+        if (workflowHistoryShortcutsEnabled)
+          handleHistoryForward()
      }
    },
    { exactMatch: true, useCapture: true },
--- a/web/app/components/workflow/hooks/use-workflow.ts
+++ b/web/app/components/workflow/hooks/use-workflow.ts
@@ -354,7 +354,7 @@ export const useWorkflow = () => {
    return startNodes
  }, [nodesMap, getRootNodesById])

-  const isValidConnection = useCallback(({ source, sourceHandle, target }: Connection) => {
+  const isValidConnection = useCallback(({ source, sourceHandle: _sourceHandle, target }: Connection) => {
    const {
      edges,
      getNodes,
--- a/web/app/components/workflow/nodes/_base/components/retry/utils.ts
+++ b/web/app/components/workflow/nodes/_base/components/retry/utils.ts
@@ -0,0 +1 @@
+export {}
--- a/web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx
+++ b/web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx
@@ -407,7 +407,10 @@ const VarReferencePicker: FC<Props> = ({
        <WrapElem onClick={() => {
          if (readonly)
            return
-          !isConstant ? setOpen(!open) : setControlFocus(Date.now())
+          if (!isConstant)
+            setOpen(!open)
+          else
+            setControlFocus(Date.now())
        }} className='group/picker-trigger-wrap relative !flex'>
          <>
            {isAddBtnTrigger
@@ -457,7 +460,10 @@ const VarReferencePicker: FC<Props> = ({
                      onClick={() => {
                        if (readonly)
                          return
-                        !isConstant ? setOpen(!open) : setControlFocus(Date.now())
+                        if (!isConstant)
+                          setOpen(!open)
+                        else
+                          setControlFocus(Date.now())
                      }}
                      className='h-full grow'
                    >
--- a/web/app/components/workflow/nodes/_base/components/variable/var-reference-vars.tsx
+++ b/web/app/components/workflow/nodes/_base/components/variable/var-reference-vars.tsx
@@ -137,7 +137,7 @@ const Item: FC<ItemProps> = ({
  const isHovering = isItemHovering || isChildrenHovering
  const open = (isObj || isStructureOutput) && isHovering
  useEffect(() => {
-    onHovering && onHovering(isHovering)
+    onHovering?.(isHovering)
  }, [isHovering])
  const handleChosen = (e: React.MouseEvent) => {
    e.stopPropagation()
--- a/web/app/components/workflow/nodes/_base/components/workflow-panel/last-run/index.tsx
+++ b/web/app/components/workflow/nodes/_base/components/workflow-panel/last-run/index.tsx
@@ -25,12 +25,12 @@ type Props = {
 } & Partial<ResultPanelProps>

 const LastRun: FC<Props> = ({
-  appId,
+  appId: _appId,
  nodeId,
  canSingleRun,
  isRunAfterSingleRun,
  updateNodeRunningStatus,
-  nodeInfo,
+  nodeInfo: _nodeInfo,
  runningStatus: oneStepRunRunningStatus,
  onSingleRunClicked,
  singleRunResult,
--- a/web/app/components/workflow/nodes/knowledge-base/components/option-card.tsx
+++ b/web/app/components/workflow/nodes/knowledge-base/components/option-card.tsx
@@ -88,7 +88,8 @@ const OptionCard = memo(({
      )}
      onClick={(e) => {
        e.stopPropagation()
-        !readonly && enableSelect && id && onClick?.(id)
+        if (!readonly && enableSelect && id)
+          onClick?.(id)
      }}
    >
      <div className={cn(
--- a/web/app/components/workflow/nodes/llm/components/json-schema-config-modal/json-schema-config.tsx
+++ b/web/app/components/workflow/nodes/llm/components/json-schema-config-modal/json-schema-config.tsx
@@ -139,8 +139,10 @@ const JsonSchemaConfig: FC<JsonSchemaConfigProps> = ({
  const handleResetDefaults = useCallback(() => {
    if (currentTab === SchemaView.VisualEditor) {
      setHoveringProperty(null)
-      advancedEditing && setAdvancedEditing(false)
-      isAddingNewField && setIsAddingNewField(false)
+      if (advancedEditing)
+        setAdvancedEditing(false)
+      if (isAddingNewField)
+        setIsAddingNewField(false)
    }
    setJsonSchema(DEFAULT_SCHEMA)
    setJson(JSON.stringify(DEFAULT_SCHEMA, null, 2))
--- a/web/app/components/workflow/nodes/llm/components/json-schema-config-modal/visual-editor/edit-card/index.tsx
+++ b/web/app/components/workflow/nodes/llm/components/json-schema-config-modal/visual-editor/edit-card/index.tsx
@@ -87,8 +87,10 @@ const EditCard: FC<EditCardProps> = ({
  })

  useSubscribe('fieldChangeSuccess', () => {
-    isAddingNewField && setIsAddingNewField(false)
-    advancedEditing && setAdvancedEditing(false)
+    if (isAddingNewField)
+      setIsAddingNewField(false)
+    if (advancedEditing)
+      setAdvancedEditing(false)
  })

  const emitPropertyNameChange = useCallback(() => {
--- a/web/app/components/workflow/nodes/llm/components/json-schema-config-modal/visual-editor/hooks.ts
+++ b/web/app/components/workflow/nodes/llm/components/json-schema-config-modal/visual-editor/hooks.ts
@@ -45,8 +45,10 @@ export const useSchemaNodeOperations = (props: VisualEditorProps) => {
      onChange(backupSchema)
      setBackupSchema(null)
    }
-    isAddingNewField && setIsAddingNewField(false)
-    advancedEditing && setAdvancedEditing(false)
+    if (isAddingNewField)
+      setIsAddingNewField(false)
+    if (advancedEditing)
+      setAdvancedEditing(false)
    setHoveringProperty(null)
  })

@@ -221,7 +223,8 @@ export const useSchemaNodeOperations = (props: VisualEditorProps) => {
  })

  useSubscribe('addField', (params) => {
-    advancedEditing && setAdvancedEditing(false)
+    if (advancedEditing)
+      setAdvancedEditing(false)
    setBackupSchema(jsonSchema)
    const { path } = params as AddEventParams
    setIsAddingNewField(true)
--- a/web/app/components/workflow/nodes/loop/components/condition-value.tsx
+++ b/web/app/components/workflow/nodes/loop/components/condition-value.tsx
@@ -22,7 +22,7 @@ type ConditionValueProps = {
 }
 const ConditionValue = ({
  variableSelector,
-  labelName,
+  labelName: _labelName,
  operator,
  value,
 }: ConditionValueProps) => {
--- a/web/app/components/workflow/panel/chat-variable-panel/components/variable-modal-trigger.tsx
+++ b/web/app/components/workflow/panel/chat-variable-panel/components/variable-modal-trigger.tsx
@@ -35,7 +35,8 @@ const VariableModalTrigger = ({
      open={open}
      onOpenChange={() => {
        setOpen(v => !v)
-        open && onClose()
+        if (open)
+          onClose()
      }}
      placement='left-start'
      offset={{
@@ -45,7 +46,8 @@ const VariableModalTrigger = ({
    >
      <PortalToFollowElemTrigger onClick={() => {
        setOpen(v => !v)
-        open && onClose()
+        if (open)
+          onClose()
      }}>
        <Button variant='primary'>
          <RiAddLine className='mr-1 h-4 w-4' />
--- a/web/app/components/workflow/panel/env-panel/variable-trigger.tsx
+++ b/web/app/components/workflow/panel/env-panel/variable-trigger.tsx
@@ -33,7 +33,8 @@ const VariableTrigger = ({
      open={open}
      onOpenChange={() => {
        setOpen(v => !v)
-        open && onClose()
+        if (open)
+          onClose()
      }}
      placement='left-start'
      offset={{
@@ -43,7 +44,8 @@ const VariableTrigger = ({
    >
      <PortalToFollowElemTrigger onClick={() => {
        setOpen(v => !v)
-        open && onClose()
+        if (open)
+          onClose()
      }}>
        <Button variant='primary'>
          <RiAddLine className='mr-1 h-4 w-4' />
--- a/web/app/components/workflow/run/index.tsx
+++ b/web/app/components/workflow/run/index.tsx
@@ -81,9 +81,12 @@ const RunPanel: FC<RunProps> = ({

  const switchTab = async (tab: string) => {
    setCurrentTab(tab)
-    if (tab === 'RESULT')
-      runDetailUrl && await getResult()
-    tracingListUrl && await getTracingList()
+    if (tab === 'RESULT') {
+      if (runDetailUrl)
+        await getResult()
+    }
+    if (tracingListUrl)
+      await getTracingList()
  }

  useEffect(() => {
--- a/web/app/components/workflow/workflow-preview/components/nodes/loop/node.tsx
+++ b/web/app/components/workflow/workflow-preview/components/nodes/loop/node.tsx
@@ -15,7 +15,7 @@ import { useNodeLoopInteractions } from './hooks'

 const Node: FC<NodeProps<LoopNodeType>> = ({
  id,
-  data,
+  data: _data,
 }) => {
  const { zoom } = useViewport()
  const nodesInitialized = useNodesInitialized()