fix oxlint warnings (#26634)

2025-10-09 10:23:34 +09:00
parent c4d8bf0ce9
commit a8746bff30
76 changed files with 261 additions and 144 deletions
--- a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx
+++ b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx
@@ -34,7 +34,8 @@ const Uploader: FC<Props> = ({
  const handleDragEnter = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target !== dragRef.current && setDragging(true)
+    if (e.target !== dragRef.current)
+      setDragging(true)
  }
  const handleDragOver = (e: DragEvent) => {
    e.preventDefault()
@@ -43,7 +44,8 @@ const Uploader: FC<Props> = ({
  const handleDragLeave = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target === dragRef.current && setDragging(false)
+    if (e.target === dragRef.current)
+      setDragging(false)
  }
  const handleDrop = (e: DragEvent) => {
    e.preventDefault()
--- a/web/app/components/datasets/create/file-uploader/index.tsx
+++ b/web/app/components/datasets/create/file-uploader/index.tsx
@@ -185,7 +185,8 @@ const FileUploader = ({
  const handleDragEnter = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target !== dragRef.current && setDragging(true)
+    if (e.target !== dragRef.current)
+      setDragging(true)
  }
  const handleDragOver = (e: DragEvent) => {
    e.preventDefault()
@@ -194,7 +195,8 @@ const FileUploader = ({
  const handleDragLeave = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target === dragRef.current && setDragging(false)
+    if (e.target === dragRef.current)
+      setDragging(false)
  }
  type FileWithPath = {
    relativePath?: string
--- a/web/app/components/datasets/create/step-two/index.tsx
+++ b/web/app/components/datasets/create/step-two/index.tsx
@@ -568,9 +568,9 @@ const StepTwo = ({
        params,
        {
          onSuccess(data) {
-            updateIndexingTypeCache && updateIndexingTypeCache(indexType as string)
-            updateResultCache && updateResultCache(data)
-            updateRetrievalMethodCache && updateRetrievalMethodCache(retrievalConfig.search_method as string)
+            updateIndexingTypeCache?.(indexType as string)
+            updateResultCache?.(data)
+            updateRetrievalMethodCache?.(retrievalConfig.search_method as string)
          },
        },
      )
@@ -578,17 +578,18 @@ const StepTwo = ({
    else {
      await createDocumentMutation.mutateAsync(params, {
        onSuccess(data) {
-          updateIndexingTypeCache && updateIndexingTypeCache(indexType as string)
-          updateResultCache && updateResultCache(data)
-          updateRetrievalMethodCache && updateRetrievalMethodCache(retrievalConfig.search_method as string)
+          updateIndexingTypeCache?.(indexType as string)
+          updateResultCache?.(data)
+          updateRetrievalMethodCache?.(retrievalConfig.search_method as string)
        },
      })
    }
    if (mutateDatasetRes)
      mutateDatasetRes()
    invalidDatasetList()
-    onStepChange && onStepChange(+1)
-    isSetting && onSave && onSave()
+    onStepChange?.(+1)
+    if (isSetting)
+      onSave?.()
  }

  useEffect(() => {
@@ -1026,7 +1027,7 @@ const StepTwo = ({
        {!isSetting
          ? (
            <div className='mt-8 flex items-center py-2'>
-              <Button onClick={() => onStepChange && onStepChange(-1)}>
+              <Button onClick={() => onStepChange?.(-1)}>
                <RiArrowLeftLine className='mr-1 h-4 w-4' />
                {t('datasetCreation.stepTwo.previousStep')}
              </Button>
--- a/web/app/components/datasets/create/website/jina-reader/base/options-wrap.tsx
+++ b/web/app/components/datasets/create/website/jina-reader/base/options-wrap.tsx
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx
@@ -200,7 +200,8 @@ const LocalFile = ({
  const handleDragEnter = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target !== dragRef.current && setDragging(true)
+    if (e.target !== dragRef.current)
+      setDragging(true)
  }
  const handleDragOver = (e: DragEvent) => {
    e.preventDefault()
@@ -209,7 +210,8 @@ const LocalFile = ({
  const handleDragLeave = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target === dragRef.current && setDragging(false)
+    if (e.target === dragRef.current)
+      setDragging(false)
  }

  const handleDrop = useCallback((e: DragEvent) => {
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/website-crawl/base/crawled-result.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/website-crawl/base/crawled-result.tsx
@@ -45,10 +45,13 @@ const CrawledResult = ({

  const handleItemCheckChange = useCallback((item: CrawlResultItem) => {
    return (checked: boolean) => {
-      if (checked)
-        isMultipleChoice ? onSelectedChange([...checkedList, item]) : onSelectedChange([item])
-      else
-        onSelectedChange(checkedList.filter(checkedItem => checkedItem.source_url !== item.source_url))
+      if (checked) {
+        if (isMultipleChoice)
+          onSelectedChange([...checkedList, item])
+        else
+          onSelectedChange([item])
+      }
+      else { onSelectedChange(checkedList.filter(checkedItem => checkedItem.source_url !== item.source_url)) }
    }
  }, [checkedList, onSelectedChange, isMultipleChoice])

--- a/web/app/components/datasets/documents/create-from-pipeline/index.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/index.tsx
@@ -326,7 +326,10 @@ const CreateFormPipeline = () => {
  }, [])

  const handleSubmit = useCallback((data: Record<string, any>) => {
-    isPreview.current ? handlePreviewChunks(data) : handleProcess(data)
+    if (isPreview.current)
+      handlePreviewChunks(data)
+    else
+      handleProcess(data)
  }, [handlePreviewChunks, handleProcess])

  const handlePreviewFileChange = useCallback((file: DocumentItem) => {
--- a/web/app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx
+++ b/web/app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx
@@ -99,7 +99,8 @@ const CSVUploader: FC<Props> = ({
  const handleDragEnter = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target !== dragRef.current && setDragging(true)
+    if (e.target !== dragRef.current)
+      setDragging(true)
  }
  const handleDragOver = (e: DragEvent) => {
    e.preventDefault()
@@ -108,7 +109,8 @@ const CSVUploader: FC<Props> = ({
  const handleDragLeave = (e: DragEvent) => {
    e.preventDefault()
    e.stopPropagation()
-    e.target === dragRef.current && setDragging(false)
+    if (e.target === dragRef.current)
+      setDragging(false)
  }
  const handleDrop = (e: DragEvent) => {
    e.preventDefault()
--- a/web/app/components/datasets/documents/detail/completed/index.tsx
+++ b/web/app/components/datasets/documents/detail/completed/index.tsx
@@ -284,7 +284,8 @@ const Completed: FC<ICompletedProps> = ({
      onSuccess: () => {
        notify({ type: 'success', message: t('common.actionMsg.modifiedSuccessfully') })
        resetList()
-        !segId && setSelectedSegmentIds([])
+        if (!segId)
+          setSelectedSegmentIds([])
      },
      onError: () => {
        notify({ type: 'error', message: t('common.actionMsg.modifiedUnsuccessfully') })
@@ -438,7 +439,8 @@ const Completed: FC<ICompletedProps> = ({
    }
    else {
      resetList()
-      currentPage !== totalPages && setCurrentPage(totalPages)
+      if (currentPage !== totalPages)
+        setCurrentPage(totalPages)
    }
  }, [segmentListData, limit, currentPage, resetList])

@@ -491,7 +493,8 @@ const Completed: FC<ICompletedProps> = ({
    }
    else {
      resetChildList()
-      currentPage !== totalPages && setCurrentPage(totalPages)
+      if (currentPage !== totalPages)
+        setCurrentPage(totalPages)
    }
  }, [childChunkListData, limit, currentPage, resetChildList])

--- a/web/app/components/datasets/documents/detail/metadata/index.tsx
+++ b/web/app/components/datasets/documents/detail/metadata/index.tsx
@@ -66,7 +66,7 @@ export const FieldInfo: FC<IFieldInfoProps> = ({
          ? displayedValue
          : inputType === 'select'
            ? <SimpleSelect
-              onSelect={({ value }) => onUpdate && onUpdate(value as string)}
+              onSelect={({ value }) => onUpdate?.(value as string)}
              items={selectOptions}
              defaultValue={value}
              className={s.select}
@@ -75,7 +75,7 @@ export const FieldInfo: FC<IFieldInfoProps> = ({
            />
            : inputType === 'textarea'
              ? <AutoHeightTextarea
-                onChange={e => onUpdate && onUpdate(e.target.value)}
+                onChange={e => onUpdate?.(e.target.value)}
                value={value}
                className={s.textArea}
                placeholder={`${t('datasetDocuments.metadata.placeholder.add')}${label}`}
--- a/web/app/components/datasets/documents/detail/settings/pipeline-settings/index.tsx
+++ b/web/app/components/datasets/documents/detail/settings/pipeline-settings/index.tsx
@@ -148,7 +148,10 @@ const PipelineSettings = ({
  }, [])

  const handleSubmit = useCallback((data: Record<string, any>) => {
-    isPreview.current ? handlePreviewChunks(data) : handleProcess(data)
+    if (isPreview.current)
+      handlePreviewChunks(data)
+    else
+      handleProcess(data)
  }, [handlePreviewChunks, handleProcess])

  if (isFetchingLastRunData) {
--- a/web/app/components/datasets/hit-testing/textarea.tsx
+++ b/web/app/components/datasets/hit-testing/textarea.tsx
@@ -80,7 +80,8 @@ const TextAreaWithButton = ({
      onUpdateList?.()
    }
    setLoading(false)
-    _onSubmit && _onSubmit()
+    if (_onSubmit)
+      _onSubmit()
  }

  const externalRetrievalTestingOnSubmit = async () => {
--- a/web/app/components/datasets/list/dataset-card/index.tsx
+++ b/web/app/components/datasets/list/dataset-card/index.tsx
@@ -157,12 +157,12 @@ const DatasetCard = ({
        data-disable-nprogress={true}
        onClick={(e) => {
          e.preventDefault()
-          isExternalProvider
-            ? push(`/datasets/${dataset.id}/hitTesting`)
-            // eslint-disable-next-line sonarjs/no-nested-conditional
-            : isPipelineUnpublished
-              ? push(`/datasets/${dataset.id}/pipeline`)
-              : push(`/datasets/${dataset.id}/documents`)
+          if (isExternalProvider)
+            push(`/datasets/${dataset.id}/hitTesting`)
+          else if (isPipelineUnpublished)
+            push(`/datasets/${dataset.id}/pipeline`)
+          else
+            push(`/datasets/${dataset.id}/documents`)
        }}
      >
        {!dataset.embedding_available && (
--- a/web/app/components/datasets/loading.tsx
+++ b/web/app/components/datasets/loading.tsx
@@ -0,0 +1,3 @@
+const DatasetsLoading = () => null
+
+export default DatasetsLoading
--- a/web/app/components/datasets/preview/index.tsx
+++ b/web/app/components/datasets/preview/index.tsx
@@ -0,0 +1,3 @@
+const DatasetPreview = () => null
+
+export default DatasetPreview