chore: apply ty checks on api code with script and ci action (#24653)

api/core/tools/builtin_tool/provider.py

@@ -74,7 +74,7 @@ class BuiltinToolProviderController(ToolProviderController):
             tool = load_yaml_file(path.join(tool_path, tool_file), ignore_error=False)
 
             # get tool class, import the module
-            assistant_tool_class: type[BuiltinTool] = load_single_subclass_from_source(
+            assistant_tool_class: type = load_single_subclass_from_source(
                 module_name=f"core.tools.builtin_tool.providers.{provider}.tools.{tool_name}",
                 script_path=path.join(
                     path.dirname(path.realpath(__file__)),

api/core/tools/tool_label_manager.py

@@ -26,7 +26,7 @@ class ToolLabelManager:
         labels = cls.filter_tool_labels(labels)
 
         if isinstance(controller, ApiToolProviderController | WorkflowToolProviderController):
-            provider_id = controller.provider_id
+            provider_id = controller.provider_id  # ty: ignore [unresolved-attribute]
         else:
             raise ValueError("Unsupported tool type")
 
@@ -51,7 +51,7 @@ class ToolLabelManager:
         Get tool labels
         """
         if isinstance(controller, ApiToolProviderController | WorkflowToolProviderController):
-            provider_id = controller.provider_id
+            provider_id = controller.provider_id  # ty: ignore [unresolved-attribute]
         elif isinstance(controller, BuiltinToolProviderController):
             return controller.tool_labels
         else:
@@ -85,7 +85,7 @@ class ToolLabelManager:
         provider_ids = []
         for controller in tool_providers:
             assert isinstance(controller, ApiToolProviderController | WorkflowToolProviderController)
-            provider_ids.append(controller.provider_id)
+            provider_ids.append(controller.provider_id)  # ty: ignore [unresolved-attribute]
 
         labels: list[ToolLabelBinding] = (
             db.session.query(ToolLabelBinding).where(ToolLabelBinding.tool_id.in_(provider_ids)).all()

api/core/tools/utils/dataset_retriever/dataset_retriever_base_tool.py

@@ -1,7 +1,6 @@
-from abc import abstractmethod
+from abc import ABC, abstractmethod
 from typing import Optional
 
-from msal_extensions.persistence import ABC  # type: ignore
 from pydantic import BaseModel, ConfigDict
 
 from core.callback_handler.index_tool_callback_handler import DatasetIndexToolCallbackHandler